Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear default manifest name if product flag used with sync #412

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

amartin120
Copy link
Contributor

@amartin120 amartin120 commented Feb 7, 2025

Please check below, if the PR fulfills these requirements:

  • Commit(s) and code follow the repositories guidelines.
  • Test(s) have been added or updated to support these change(s).
  • Doc(s) have been added or updated to support these change(s).

Associated Links:

Types of Changes:

  • Bugfix

Proposed Changes:

  • If --products is used on the sync command, clear the default manifest filename. Otherwise hauler will process the --products flag and then attempt to process the "default" filename.

  • This approach ensures:
    ✅ --filename isn't forced when using --products.
    ✅ Users can still use both flags together if they explicitly provide --filename.
    ✅ If no flags are passed, filename retains its default value.

Verification/Testing of Changes:

  • Before:
    image

  • After:
    image

Additional Context:

Signed-off-by: Adam Martin <adam.martin@ranchergovernment.com>
Signed-off-by: Adam Martin <adam.martin@ranchergovernment.com>
@zackbradys zackbradys merged commit eb275b9 into hauler-dev:main Feb 7, 2025
2 checks passed
@amartin120 amartin120 deleted the sync-fix branch February 7, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants